Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed case of expression in OOTB report. #17191

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

h-kataria
Copy link
Contributor

This was causing an issue when copying this report and trying to change an expression of new report.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558087

@gtanzillo please review/verify.

was getting error prior to fix:
Error building timeline PG::UndefinedTable: ERROR: missing FROM-clause entry for table "miq_sets" LINE 1: ...s"."ems_id" AS t0_r15 FROM "policy_events" WHERE ("miq_sets"... ^ : SELECT "policy_events"."id" AS t0_r0, "policy_events"."miq_event_definition_id" AS t0_r1, "policy_events"."event_type" AS t0_r2, "policy_events"."miq_event_definition_description" AS t0_r3, "policy_events"."miq_policy_id" AS t0_r4, "policy_events"."miq_policy_description" AS t0_r5, "policy_events"."result" AS t0_r6, "policy_events"."timestamp" AS t0_r7, "policy_events"."target_id" AS t0_r8, "policy_events"."target_class" AS t0_r9, "policy_events"."target_name" AS t0_r10, "policy_events"."chain_id" AS t0_r11, "policy_events"."username" AS t0_r12, "policy_events"."host_id" AS t0_r13, "policy_events"."ems_cluster_id" AS t0_r14, "policy_events"."ems_id" AS t0_r15 FROM "policy_events" WHERE ("miq_sets"."created_on" BETWEEN '2018-03-19 00:00:00' AND '2018-03-25 23:59:59.999999')

after fix:
after

This was causing an issue when copying this report and trying to change an expression of new report.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558087
@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2018

Checked commit h-kataria@8b167fd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit 1e090d9 into ManageIQ:master Mar 26, 2018
@bdunne bdunne added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 26, 2018
@bdunne bdunne assigned bdunne and unassigned gtanzillo Mar 26, 2018
simaishi pushed a commit that referenced this pull request Mar 27, 2018
…eport

Fixed case of expression in OOTB report.
(cherry picked from commit 1e090d9)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561079
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d554974fe4211eacd1b98e74d62e93b65e2aa31f
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Mon Mar 26 16:18:50 2018 -0400

    Merge pull request #17191 from h-kataria/change_case_of_exp_in_ootb_report
    
    Fixed case of expression in OOTB report.
    (cherry picked from commit 1e090d91579fe413dd4ce58af86508c5ca24b006)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561079

@h-kataria h-kataria deleted the change_case_of_exp_in_ootb_report branch April 14, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants